DB2/DB2as400 glue get table api issue fix #2506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulR3hman
force-pushed
the
db2_phase2_tablelist_issue
branch
from
157e43e to
5687505
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2506 +/- ##
============================================
+ Coverage 61.09% 61.18% +0.08%
- Complexity 3738 3752 +14
============================================
Files 576 577 +1
Lines 21348 21437 +89
Branches 2654 2661 +7
============================================
+ Hits 13043 13116 +73
- Misses 7037 7051 +14
- Partials 1268 1270 +2 ☔ View full report in Codecov by Sentry. |
AbdulR3hman
force-pushed
the
db2_phase2_tablelist_issue
branch
from
5687505 to
95fb6a9
Compare
AbdulR3hman
reviewed
Jan 10, 2025
| @@ -77,7 +77,7 @@ | |||
| public class Db2As400MetadataHandler extends JdbcMetadataHandler | |||
| { | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(Db2As400MetadataHandler.class); | |||
| static final String PARTITION_NUMBER = "PARTITION_NUMBER"; | |||
| static final String PARTITION_NUMBER = "PARTITION_NUMBER".toLowerCase(); | |||
There was a problem hiding this comment.
nit; static final String PARTITION_NUMBER = "partition_number";
AbdulR3hman
reviewed
Jan 10, 2025
| @@ -86,7 +86,7 @@ | |||
| public class Db2MetadataHandler extends JdbcMetadataHandler | |||
| { | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(Db2MetadataHandler.class); | |||
| static final String PARTITION_NUMBER = "PARTITION_NUMBER"; | |||
| static final String PARTITION_NUMBER = "PARTITION_NUMBER".toLowerCase(); | |||
There was a problem hiding this comment.
nit; static final String PARTITION_NUMBER = "partition_number";
|
question; has this been tested with and without glue connection? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The DB2/DB2as400 Glue Get Table API was not retrieving data as expected due to a case-sensitivity issue with the PARTITION_NUMBER. By converting the PARTITION_NUMBER column to lowercase, we achieved successful data retrieval through the Glue API.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.