Add port number as a DBS_PORT parameter in Teradata JDBC Connection String #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jithendar12
force-pushed
the
panama-sdkv2-gdcv2-trianz
branch
from
4761d30 to
1979de0
Compare
Jithendar12
force-pushed
the
panama-sdkv2-gdcv2-trianz
branch
from
1979de0 to
c3d9cb3
Compare
Jithendar12
force-pushed
the
panama-sdkv2-gdcv2-trianz
branch
2 times, most recently
from
e3ddbfd to
910f5c5
Compare
Jithendar12
changed the title
Jithendar12
force-pushed
the
panama-sdkv2-gdcv2-trianz
branch
from
910f5c5 to
5d62c49
Compare
AbdulR3hman
force-pushed
the
panama-sdkv2-gdcv2-trianz
branch
from
5d62c49 to
ebf8eb4
Compare
AbdulR3hman
reviewed
Jan 10, 2025
| { | ||
| HashMap<String, String> environment = new HashMap<>(); | ||
| // Default port for teradata is 1025 | ||
| String port = connectionProperties.getOrDefault(PORT, "1025"); |
There was a problem hiding this comment.
Please move this to the Teradata constants; not here.
AbdulR3hman
reviewed
Jan 10, 2025
|
|
||
| // Construct the JDBC connection string and include the port as a DBS_PORT parameter | ||
| String connectionString = getConnectionStringPrefix(connectionProperties) + connectionProperties.get(HOST) | ||
| + getDatabase(connectionProperties) + ",DBS_PORT=" + port + getJdbcParameters(connectionProperties); |
There was a problem hiding this comment.
this is assuming a new change; will this break existing customers? what exactly promoted this change? I want to make sure this is backward compatible; i.e.; existing customers who are upgrading won't have their environments broken.
AbdulR3hman
reviewed
Jan 10, 2025
|
|
||
| public class TeradataEnvironmentProperties extends JdbcEnvironmentProperties | ||
| { | ||
| @Override | ||
| public Map<String, String> connectionPropertiesToEnvironment(Map<String, String> connectionProperties) |
There was a problem hiding this comment.
let's add a unit test once questions below are answered.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2452 +/- ##
============================================
+ Coverage 61.09% 61.15% +0.06%
- Complexity 3738 3751 +13
============================================
Files 576 577 +1
Lines 21348 21441 +93
Branches 2654 2661 +7
============================================
+ Hits 13043 13113 +70
- Misses 7037 7057 +20
- Partials 1268 1271 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The Teradata JDBC connection string requires a specific format to include the port number.
Example URL:
jdbc:teradata://host/TMODE=ANSI,CHARSET=UTF8,DATABASE=TEST,DBS_PORT=1025,user=dummy,password=dummy
Previously, the port was included in the connection string as host:port, which was not compatible with the Teradata JDBC driver
Description of changes:
Overridden the connectionPropertiesToEnvironment method to include the port number as a DBS_PORT parameter.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.