Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlserver in the query editor always returns UPPERCASE table names issue fix #2435

Merged

Conversation

VenkatasivareddyTR
Copy link
Contributor

Issue #, if available:

Description of changes:
Sqlserver in the query editor always returns UPPERCASE table names even though if we created sqlserver tables with lowercase table names. This is because of we are always converting requested table name to UPPERCASE in doGetTable function.
After removing this uppercase conversion then it's returning both lowercase and uppercase table names in the query editor.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@macohen macohen requested a review from ejeffrli December 12, 2024 15:05
@VenkatasivareddyTR VenkatasivareddyTR force-pushed the sqlserver_table_casingissue branch from a2ada61 to 4288128 Compare January 3, 2025 11:12
@ejeffrli ejeffrli merged commit 09e8689 into awslabs:master Jan 9, 2025
6 checks passed
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.17%. Comparing base (7b40bf4) to head (47eb255).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2435      +/-   ##
============================================
+ Coverage     61.09%   61.17%   +0.07%     
- Complexity     3738     3751      +13     
============================================
  Files           576      577       +1     
  Lines         21348    21435      +87     
  Branches       2654     2661       +7     
============================================
+ Hits          13043    13113      +70     
- Misses         7037     7051      +14     
- Partials       1268     1271       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants