Bug Fixes Glue Integration

awslabs · Jan 16, 2024 · cc02fa4 · cc02fa4
1 parent 01d7997
commit cc02fa4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/...deration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/GlueConnectionUtils.java b/...deration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/GlueConnectionUtils.java
@@ -51,9 +51,10 @@ public static Map<String, String> getGlueConnection()
         String glueConnectionName = envConfig.get(DEFAULT_GLUE_CONNECTION);
         if (glueConnectionName != null) {
             HashMap<String, String> cachedConfig = connectionNameCache.get(glueConnectionName);
-            if (cachedConfig != null) {
+            if (cachedConfig == null) {
                 try {
                     HashMap<String, HashMap<String, String>> athenaDriverPropertiesToMap = new HashMap<String, HashMap<String, String>>();
+
                     AWSGlue awsGlue = AWSGlueClientBuilder.standard().withClientConfiguration(new ClientConfiguration().withConnectionTimeout(CONNECT_TIMEOUT)).build();
                     GetConnectionResult glueConnection = awsGlue.getConnection(new GetConnectionRequest().withName(glueConnectionName));
                     Connection connection = glueConnection.getConnection();
@@ -74,6 +75,8 @@ public static Map<String, String> getGlueConnection()
                 catch (Exception err) {
                     logger.error("Error thrown during fetching of {} connection properties. {}", glueConnectionName, err.toString());
                 }
+            }else{
+                return cachedConfig;
             }
         }
         else {            

diff --git a/...java/com/amazonaws/athena/connectors/jdbc/connection/DatabaseConnectionConfigBuilder.java b/...java/com/amazonaws/athena/connectors/jdbc/connection/DatabaseConnectionConfigBuilder.java
@@ -96,7 +96,7 @@ public List<DatabaseConnectionConfig> build()
         List<DatabaseConnectionConfig> databaseConnectionConfigs = new ArrayList<>();
 
         int numberOfCatalogs = 0;
-        if (StringUtils.isBlank(properties.get(DEFAULT_GLUE_CONNECTION))) {
+        if (!StringUtils.isBlank(properties.get(DEFAULT_GLUE_CONNECTION))) {
             databaseConnectionConfigs.add(extractDatabaseGlueConnectionConfig(DEFAULT_CONNECTION_STRING_PROPERTY));
             numberOfCatalogs++;
         }

diff --git a/athena-jdbc/src/main/java/com/amazonaws/athena/connectors/jdbc/manager/JDBCUtil.java b/athena-jdbc/src/main/java/com/amazonaws/athena/connectors/jdbc/manager/JDBCUtil.java
@@ -54,12 +54,10 @@ public static DatabaseConnectionConfig getSingleDatabaseConfigFromEnv(String dat
         List<DatabaseConnectionConfig> databaseConnectionConfigs = DatabaseConnectionConfigBuilder.buildFromSystemEnv(databaseEngine, configOptions);
 
         for (DatabaseConnectionConfig databaseConnectionConfig : databaseConnectionConfigs) {
-            if (DatabaseConnectionConfigBuilder.DEFAULT_CONNECTION_STRING_PROPERTY.equals(databaseConnectionConfig.getCatalog())
-                    && databaseEngine.equals(databaseConnectionConfig.getEngine())) {
+            if (DatabaseConnectionConfigBuilder.DEFAULT_CONNECTION_STRING_PROPERTY.equals(databaseConnectionConfig.getCatalog())) {
                 return databaseConnectionConfig;
             }
         }
-
         throw new RuntimeException(String.format("Must provide default connection string parameter %s for database type %s",
                 DatabaseConnectionConfigBuilder.DEFAULT_CONNECTION_STRING_PROPERTY, databaseEngine));
     }