deps(al2): update logic for pulling cni plugins and bump version #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
changed the title
| local os="linux" | ||
| local arch="$ARCH" | ||
| local version="" | ||
| while getopts 'n:o:a:v:' OPTION; do |
There was a problem hiding this comment.
using this in a function is a bit odd IMO. positional args would be more verbose in some places, but simpler to grok
There was a problem hiding this comment.
i agree 😅 looking for something with sane defaults and the ability to override that wasn't too verbose, ill either keep iterating on it or just inline all the paths
| local binary_name="" | ||
| local os="linux" | ||
| local arch="$ARCH" | ||
| local version="" |
There was a problem hiding this comment.
how could we support a version marker for binaries? e.g.
bin/$binary_name/latest.txt => 1.2.3
bin/$binary_name/1.2.3/$os/$arch/$binary_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updates the binary artifact storage scheme for the
cni-pluginsbundleBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.