Added an optional kernel parameter test to Packer Build #1929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
In the past, a few users have experienced major issues caused by changing kernel parameters from Amazon Linux upstream that were not caught by amazon-eks-ami maintainers. This PR aims at reducing the risk of releasing breaking changes by comparing the built kernel parameters against the set of 'known good' kernel parameters (in
templates/shared/resources/
).make sysctl_test_throw_err=true
, causing any differences in the kernel parameters to fail the build.sysctl_logs
folder.known good
kernel parameters, simplycp ./sysctl_logs/* ./templates/shared/resources/
sysctl_logs
, so no further conversion is needed.There also exists a blacklist (
templates/shared/resources/sysctl_blacklist
) for kernel parameters that are highly volatile and shouldn't be compared (ex;kernel.random.uuid
). This blacklist uses regex and thediff -I
flag to ignore certain parameters.Added functionality to the existing
validate.sh
to compare the kernel parameters (via a sysctl -a -e output) against the set of 'known good' kernel parameters.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
sysctl_blacklist
works as intended and accepts changes.sysctl_test_throw_err
flag works as intended.See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.