Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip validating the pbc registry for non-regional curated packages flow #8981

Merged

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Nov 7, 2024

Description of changes:
This PR skips validating the pbc registry for non-regional curated packages flow as a follow-up to #8910.

Testing (if applicable):

make eks-a
make lint
make unit-test
make build-all-test-binaries
make generate
make generate-manifests
make release-manifests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999
Copy link
Member Author

sp1999 commented Nov 7, 2024

/approve

@eks-distro-bot eks-distro-bot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2024
@sp1999
Copy link
Member Author

sp1999 commented Nov 7, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999
Copy link
Member Author

sp1999 commented Nov 7, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented Nov 7, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.41%. Comparing base (44f8920) to head (016a23a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8981   +/-   ##
=======================================
  Coverage   72.41%   72.41%           
=======================================
  Files         578      578           
  Lines       45386    45386           
=======================================
  Hits        32866    32866           
  Misses      10790    10790           
  Partials     1730     1730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhaanvi5
Copy link
Member

jhaanvi5 commented Nov 7, 2024

/lgtm

@eks-distro-bot eks-distro-bot merged commit c448e9e into aws:main Nov 7, 2024
9 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8982

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8983

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants