Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop previous versions of copilot from downgrading stack set #5141

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

dannyrandall
Copy link
Contributor

Fixes #5140

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@dannyrandall dannyrandall requested a review from a team as a code owner July 28, 2023 21:21
@dannyrandall dannyrandall requested review from Lou1415926 and removed request for a team July 28, 2023 21:21
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51488 51400 +0.17
macOS (arm) 51684 51604 +0.16
linux (amd) 45324 45244 +0.18
linux (arm) 43588 43524 +0.15
windows (amd) 42140 42072 +0.16

@codecov-commenter
Copy link

Codecov Report

Merging #5141 (eb0d4e0) into mainline (bde9220) will increase coverage by 0.07%.
Report is 1 commits behind head on mainline.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           mainline    #5141      +/-   ##
============================================
+ Coverage     69.46%   69.54%   +0.07%     
============================================
  Files           295      295              
  Lines         43296    43326      +30     
  Branches        285      285              
============================================
+ Hits          30076    30130      +54     
+ Misses        11750    11728      -22     
+ Partials       1470     1468       -2     
Files Changed Coverage Δ
internal/pkg/deploy/cloudformation/stack/app.go 86.74% <100.00%> (+0.32%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice thanks!

Copy link
Contributor

@KollaAdithya KollaAdithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@mergify mergify bot merged commit b63758c into aws:mainline Jul 31, 2023
12 checks passed
@dannyrandall dannyrandall deleted the fix/iss-5140 branch July 31, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot unmarshal !!str See #5140 into []string
4 participants