-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable ctrl-c only after changeset is created and executed #5112
chore: enable ctrl-c only after changeset is created and executed #5112
Conversation
🍕 Here are the new binary sizes!
|
Codecov Report
@@ Coverage Diff @@
## mainline #5112 +/- ##
============================================
- Coverage 69.73% 69.66% -0.08%
============================================
Files 293 295 +2
Lines 43003 43243 +240
Branches 285 285
============================================
+ Hits 29988 30124 +136
- Misses 11552 11643 +91
- Partials 1463 1476 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just to double check: do we need to update the deploy and jobdeploy with the same thing?
With this PR we are already enabling |
Co-authored-by: Danny Randall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i love this PR!🚀 just some small nits and one more question 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Even though this PR looks big, half of the changes are just unit tests.
Better solution than #5097
Old Approach:
I closed PR 5097. In the previous PR #5097, there is a drawback with the logic when users initiated a ctrl-c interruption during the process of
proposing infrastructure changes
. The issue was that the interruption signal (SIGINT) was being captured even before the changeset is created and executed. As a result, when the user pressed ctrl-c duringproposing infrastructure changes
, we display a message likeReceived interrupt for ctrl-c
; However, despite the interruption, the code continued to create and execute the changeset, leading to the stack creation process continuing even after the user intended to stop it.New Approach:
To address the issue, this PR had a better solution for handling ctrl-c interruptions during the process of proposing infrastructure changes. Listening to the SIGINT signal is performed only after the changeset is created and executed. The necessary changes to achieve this have been made by relocating the complete logic for waiting and handling the signal to the
deploy/cloudformation
package.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.