Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish snapshots #206

Merged
merged 9 commits into from
Sep 7, 2020
Merged

Publish snapshots #206

merged 9 commits into from
Sep 7, 2020

Conversation

anuraaga
Copy link
Contributor

  • Switches from reckon to nebula plugin which can correctly publish tag.
  • Separates PR and master build action workflow, latter publishes after building on all OS/Java
  • Signs snapshots, while not required doesn't hurt and verifies signing works on GitHub

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. My only concern is with the agent experiencing lots of changes this week, I'd rather be paranoid about the release process and hold off on merging this until next week in case I need to make any hotfix releases if you're cool with that. (Which I know this PR should actually help with, but just in case there are unforeseen issues).

@@ -1,6 +1,7 @@
pluginManagement {
plugins {
id("com.github.hierynomus.license") version "0.15.0"
id("nebula.release") version "15.1.0"
id("net.ltgt.errorprone") version "1.2.1"
id("org.ajoberstar.grgit") version "4.0.2"
id("org.ajoberstar.reckon") version "0.12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove reckon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice eyes

}
}
}
}

tasks.withType<Sign>().configureEach {
onlyIf { !isSnapshot }
onlyIf { System.getenv("CI") == "true" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will make releasing from a local machine not really possible right? That's fine with me, I just want to understand this correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to publish from local machine, we can set up the GPG env vars and CI = true locally too in the off event that we need to

env:
CI: true
publish:
name: Publish snapshots
Copy link
Contributor

@willarmiros willarmiros Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this happens fully automatically after each PR is merged, then how do we do non-snapshot releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add release-build.yml in a separate PR :)

Copy link
Contributor Author

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will hold off on merging this

env:
CI: true
publish:
name: Publish snapshots
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add release-build.yml in a separate PR :)

}
}
}
}

tasks.withType<Sign>().configureEach {
onlyIf { !isSnapshot }
onlyIf { System.getenv("CI") == "true" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to publish from local machine, we can set up the GPG env vars and CI = true locally too in the off event that we need to

@@ -1,6 +1,7 @@
pluginManagement {
plugins {
id("com.github.hierynomus.license") version "0.15.0"
id("nebula.release") version "15.1.0"
id("net.ltgt.errorprone") version "1.2.1"
id("org.ajoberstar.grgit") version "4.0.2"
id("org.ajoberstar.reckon") version "0.12.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice eyes

@anuraaga
Copy link
Contributor Author

anuraaga commented Sep 7, 2020

#211 agent was released! So going to go ahead and merge this.

@anuraaga anuraaga merged commit 37770df into aws:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants