-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish snapshots #206
Publish snapshots #206
Conversation
…nd read publishing creds from environment too for easier use from CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. My only concern is with the agent experiencing lots of changes this week, I'd rather be paranoid about the release process and hold off on merging this until next week in case I need to make any hotfix releases if you're cool with that. (Which I know this PR should actually help with, but just in case there are unforeseen issues).
settings.gradle.kts
Outdated
@@ -1,6 +1,7 @@ | |||
pluginManagement { | |||
plugins { | |||
id("com.github.hierynomus.license") version "0.15.0" | |||
id("nebula.release") version "15.1.0" | |||
id("net.ltgt.errorprone") version "1.2.1" | |||
id("org.ajoberstar.grgit") version "4.0.2" | |||
id("org.ajoberstar.reckon") version "0.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove reckon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice eyes
} | ||
} | ||
} | ||
} | ||
|
||
tasks.withType<Sign>().configureEach { | ||
onlyIf { !isSnapshot } | ||
onlyIf { System.getenv("CI") == "true" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will make releasing from a local machine not really possible right? That's fine with me, I just want to understand this correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need to publish from local machine, we can set up the GPG env vars and CI = true locally too in the off event that we need to
env: | ||
CI: true | ||
publish: | ||
name: Publish snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this happens fully automatically after each PR is merged, then how do we do non-snapshot releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to add release-build.yml in a separate PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will hold off on merging this
env: | ||
CI: true | ||
publish: | ||
name: Publish snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to add release-build.yml in a separate PR :)
} | ||
} | ||
} | ||
} | ||
|
||
tasks.withType<Sign>().configureEach { | ||
onlyIf { !isSnapshot } | ||
onlyIf { System.getenv("CI") == "true" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need to publish from local machine, we can set up the GPG env vars and CI = true locally too in the off event that we need to
settings.gradle.kts
Outdated
@@ -1,6 +1,7 @@ | |||
pluginManagement { | |||
plugins { | |||
id("com.github.hierynomus.license") version "0.15.0" | |||
id("nebula.release") version "15.1.0" | |||
id("net.ltgt.errorprone") version "1.2.1" | |||
id("org.ajoberstar.grgit") version "4.0.2" | |||
id("org.ajoberstar.reckon") version "0.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice eyes
…java into publish-snapshots
#211 agent was released! So going to go ahead and merge this. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.