Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default checksum calculation for httpChecksum to CRC32 #3090

Open
wants to merge 25 commits into
base: version-3
Choose a base branch
from
Open

Default checksum calculation for httpChecksum to CRC32 #3090

wants to merge 25 commits into from

Conversation

mullermp
Copy link
Contributor

Defaults CRC32 for httpChecksum implementations and adds CRC64 as a new algorithm.

alextwoods
alextwoods reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks good overall.

gems/aws-sdk-core/CHANGELOG.md Outdated Show resolved Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/plugins/checksum_algorithm.rb Outdated Show resolved Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/plugins/http_checksum.rb Show resolved Hide resolved
gems/aws-sdk-s3/lib/aws-sdk-s3/multipart_file_uploader.rb Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Detected 1 possible performance regressions:

  • aws-sdk-kinesis.gem_size_kb - z-score regression: 73.5 -> 74.0. Z-score: Infinity

@github-actions GitHub Actions
Copy link

Detected 4 possible performance regressions:

  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity
  • aws-sdk-s3.get_object_small_allocated_kb - z-score regression: 73.22 -> 75.33. Z-score: 21.94
  • aws-sdk-s3.get_object_large_allocated_kb - z-score regression: 21578.44 -> 21580.56. Z-score: 21.94
  • aws-sdk-s3.put_object_small_allocated_kb - z-score regression: 95.03 -> 97.18. Z-score: 22.04

@github-actions GitHub Actions
Copy link

Detected 5 possible performance regressions:

  • aws-sdk-s3.get_object_small_allocated_kb - z-score regression: 59.36 -> 61.18. Z-score: 38.49
  • aws-sdk-s3.get_object_large_allocated_kb - z-score regression: 21564.59 -> 21566.41. Z-score: 39.91
  • aws-sdk-s3.put_object_small_allocated_kb - z-score regression: 78.06 -> 80.26. Z-score: 33.0
  • aws-sdk-s3.put_object_multipart_large_allocated_kb - z-score regression: 32108.0 -> 32112.59. Z-score: 30.49
  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity

@github-actions GitHub Actions
Copy link

Detected 5 possible performance regressions:

  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity
  • aws-sdk-s3.get_object_small_allocated_kb - z-score regression: 56.73 -> 58.55. Z-score: 62.82
  • aws-sdk-s3.get_object_large_allocated_kb - z-score regression: 21561.95 -> 21563.78. Z-score: 62.82
  • aws-sdk-s3.put_object_small_allocated_kb - z-score regression: 75.16 -> 77.36. Z-score: 75.64
  • aws-sdk-s3.put_object_multipart_large_allocated_kb - z-score regression: 32096.32 -> 32100.77. Z-score: 41.97

@github-actions GitHub Actions
Copy link

Detected 5 possible performance regressions:

  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity
  • aws-sdk-s3.get_object_small_allocated_kb - z-score regression: 63.37 -> 65.42. Z-score: 72.1
  • aws-sdk-s3.get_object_large_allocated_kb - z-score regression: 25664.38 -> 25666.43. Z-score: 72.1
  • aws-sdk-s3.put_object_small_allocated_kb - z-score regression: 80.56 -> 82.92. Z-score: 82.81
  • aws-sdk-s3.put_object_multipart_large_allocated_kb - z-score regression: 32124.11 -> 32129.01. Z-score: 40.28

@github-actions GitHub Actions
Copy link

Detected 5 possible performance regressions:

  • aws-sdk-s3.get_object_small_allocated_kb - z-score regression: 70.39 -> 72.61. Z-score: 30.18
  • aws-sdk-s3.get_object_large_allocated_kb - z-score regression: 25671.4 -> 25673.62. Z-score: 30.18
  • aws-sdk-s3.put_object_small_allocated_kb - z-score regression: 90.04 -> 92.41. Z-score: 32.2
  • aws-sdk-s3.put_object_multipart_large_allocated_kb - z-score regression: 21929.59 -> 21934.58. Z-score: 15.81
  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity

@github-actions GitHub Actions
Copy link

Detected 5 possible performance regressions:

  • aws-sdk-s3.get_object_small_allocated_kb - z-score regression: 59.65 -> 61.48. Z-score: 67.13
  • aws-sdk-s3.get_object_large_allocated_kb - z-score regression: 21564.88 -> 21566.71. Z-score: 49.55
  • aws-sdk-s3.put_object_small_allocated_kb - z-score regression: 78.75 -> 80.83. Z-score: 34.14
  • aws-sdk-s3.put_object_multipart_large_allocated_kb - z-score regression: 32109.84 -> 32114.53. Z-score: 43.16
  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity

@github-actions GitHub Actions
Copy link

Detected 1 possible performance regressions:

  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity

1 similar comment
@github-actions GitHub Actions
Copy link

Detected 1 possible performance regressions:

  • aws-sdk-cloudwatchlogs.gem_size_kb - z-score regression: 112.0 -> 112.5. Z-score: Infinity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextwoods alextwoods alextwoods left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullermp @alextwoods