[develop] Switch preliminary scale-all nodes attempt to be all-or-nothing #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize job level scaling with preliminary scale-all nodes attempt. Switch this preliminary scaling from best-effort to all-or-nothing, so to remove unused instance launches Signed-off-by: Luca Carrogu <[email protected]>
EddyMM
reviewed
Aug 22, 2023
| @@ -776,7 +776,7 @@ def _scaling_for_jobs_multi_node( | |||
| self.unused_launched_instances |= self._launch_instances( | |||
There was a problem hiding this comment.
NIT: Let's fix the comment explaining this line of code (... preliminary scale-all nodes attempt ... -> ... preliminary all-or-nothing nodes attempt ...)
EddyMM
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Optimize job level scaling with preliminary scale-all nodes attempt. Switch this preliminary scaling from best-effort to all-or-nothing, so to remove unused instance launches
Tests
n/a
References
n/a
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.