fix(eventstream): move callback data shutdown into ClientContinuation…

… destructor (#437)
aws · May 25, 2022 · 7ff4354 · 7ff4354
1 parent 4492d28
commit 7ff4354
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/eventstream_rpc/source/EventStreamClient.cpp b/eventstream_rpc/source/EventStreamClient.cpp
@@ -871,18 +871,15 @@ namespace Aws
             }
             if (m_callbackData != nullptr)
             {
+                {
+                    const std::lock_guard<std::mutex> lock(m_callbackData->callbackMutex);
+                    m_callbackData->continuationDestroyed = true;
+                }
                 Crt::Delete<ContinuationCallbackData>(m_callbackData, m_allocator);
             }
         }
 
-        ClientContinuationHandler::~ClientContinuationHandler() noexcept
-        {
-            if (m_callbackData)
-            {
-                const std::lock_guard<std::mutex> lock(m_callbackData->callbackMutex);
-                m_callbackData->continuationDestroyed = true;
-            }
-        }
+        ClientContinuationHandler::~ClientContinuationHandler() noexcept {}
 
         void ClientContinuation::s_onContinuationMessage(
             struct aws_event_stream_rpc_client_continuation_token *continuationToken,