forked from tikv/crc64fast
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double throughput on systems which support AVX512 VPCLMULQDQ #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Schrodinger ZHU Yifan <[email protected]>
Signed-off-by: Schrodinger ZHU Yifan <[email protected]>
…256bit-vpclmulqdq Adding 256-bit VPCLMULQDQ support from tikv#8 # Conflicts: # Cargo.toml # src/lib.rs # src/pclmulqdq/mod.rs
…256bit-vpclmulqdq Adding 256-bit VPCLMULQDQ support from tikv#8 # Conflicts: # Cargo.toml
# Conflicts: # README.md # src/pclmulqdq/mod.rs # src/pclmulqdq/x86/mod.rs
This looks awesome! Excited to test it inside the AWS SDK. Also inspiring since I've been looking at implementing some of these checksums using WASM SIMD. |
There’s only one feature…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By leveraging Rust's emerging support for AVX512 intrinsics, specifically VPCLMULQDQ, we can massively improve throughput for x86_64 processors which support them (Intel Ice Lake+ and AMD Zen4+).
Specifically, on an
m7i.8xlarge
EC2 instance (4th gen Xeon, aka Sapphire Rapids), throughput approximately doubles from ~26GiB/s to ~52GiB/s.Since these are currently marked as unstable features in Rust, builds require using
nightly
and enabling thevpclmulqdq
feature:This originated from feat: add 256bit vpclmulqdq support PR from the origin crc64fast project.