Add static check with "avocado-static-checks" #14
Conversation
clebergnu
force-pushed
the
add_static_check_import_sort
branch
13 times, most recently
from
8411e93
to
09c668e
Compare
There was a problem hiding this comment.
Hi @clebergnu, thank you for this. This is a great solution for consolidation of static-check around avocado projects. I have just one proposal to the way how we will run the static-checks in the github workflow.
.github/workflows/modules-tests.yml
Outdated
| - name: Install requirements for the static checks | ||
| run: pip3 install -r static-checks/requirements.txt | ||
|
|
||
| - name: Runs the static check for import order |
There was a problem hiding this comment.
IMO, we shouldn't have separated step for each static-check. Because when we introduce new static-check in avocado-static-checks repo, we will need to update every workflow which uses it. IMO, we should have a script inside avocado-static-checks repo which will run all static-checks, and we will use it here in this step.
There was a problem hiding this comment.
Sounds reasonable. I've opened a PR (avocado-framework/avocado-static-checks#2) that adds such script, and will update this if/when approved.
clebergnu
force-pushed
the
add_static_check_import_sort
branch
2 times, most recently
from
b0f95ef
to
8d05b7b
Compare
Adds a Python module import order check. This is based on "avocado-static-checks", which is being added here as a submodule. The idea is to use the same checks in all "avocado-framework" projects without having to maintain different versions of the static check code/wrappers. Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
add_static_check_import_sort
branch
from
8d05b7b
to
64c3cf6
Compare
Adds a Python module import order check.
This is based on "avocado-static-checks", which is being added here as a submodule. The idea is to use the same checks in all "avocado-framework" projects without having to maintain different versions of the static check code/wrappers.