Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust imports & cleanup unused gcp util functions #118

Merged
merged 3 commits into from
Mar 13, 2024
Merged

chore: adjust imports & cleanup unused gcp util functions #118

merged 3 commits into from
Mar 13, 2024

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Mar 12, 2024 •
edited
Loading

Describe your changes

  • Fix missing import bug
  • Clean up wanna.core.utils.gcp
  • remove duplicated call to get gcp project_nbumeric id

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@jsilva jsilva requested review from racinmat and mi-char March 12, 2024 18:55
@jsilva jsilva marked this pull request as ready for review March 12, 2024 18:55
racinmat
racinmat approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
00191-761555425

@jsilva jsilva merged commit a85a84c into master Mar 13, 2024
4 checks passed
@jsilva jsilva deleted the joao/fix-import branch March 13, 2024 06:29
@racinmat racinmat mentioned this pull request Mar 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racinmat racinmat racinmat approved these changes

@mi-char mi-char Awaiting requested review from mi-char

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsilva @racinmat