More Sonar Fixes #193
Closed
More Sonar Fixes #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes changes I'm not comfortable with. I'll look to apply the changes that we can later. |
elaborate?? |
|
The diff of NumberParser isn't humanly parsable without excessively high levels of coffee - it does too much. |
|
We'll have to get to it eventually, but sure I can take those out |
rob-bygrave
added a commit
that referenced
this pull request
Jan 11, 2024
rob-bygrave
added a commit
that referenced
this pull request
Jan 11, 2024
Sonar improvements from #193
|
Replaced this with #202 - Sorry, I should have been clearer ... I wasn't happy with the diff for NumberParser and wanted any changes to NumberParser to be done nicely, clearly, slowly etc. I've pulled the other changes into 202 and merged that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.