ACP 99 reference implementation improvements #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Improves upon #700 by making the following changes to align the rest of the validator manager contracts with ACP-99:
IValidatorManager
, asACP99Manager
captures the functionality that validator managers must implement.initializeValidatorRegistration
,initializeDelegatorRegistration
, etc methods toinitiate
to reflect the naming convention used in ACP-99. These methods initiate a process; they do not initialize any data. Note thatinitializeValidatorSet
is not renamed, since this method does perform initialization.PoSValidatorManager
to conform to the ACP-99 naming conventions for validator management.ValidatorRegistrationInput
in favor of providing the fields as standalone arguments. This matches ACP-99, as well as reduces the contract size.How this works
See above
How this was tested
CI
How is this documented
The same changes above apply to the README