Map circular input region of the joysticks to a square region, improved user interface. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the device name was converted to lower case, but not the search term for the input device. Therefore the input device could not be found by using the default search term, or by its name as it was displayed in "bluetoothctl".
* Throttle & angle are on different analog sticks. On the old mapping full steering could only be applied with zero throttle. (The shape of the analog sticks' maximum deflection is a circle.) * Separate buttons for 'start recording' and 'stop recording'. * Separate buttons for manual driving mode and automatic driving mode. The automatic driving mode button toggles between: 'automatic steering' and 'automatic steering and throttle'
Throttle and angle are independent, and therefore need a rectangular input area. This change maps the 45 degree positions to maximum values in both channels. Additionally a variable scaling for the angle was added.
This avoids unexpected acceleration.
Also improves comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More conventional command line user interface, and better reporting of possible problems.
Maps circular input region of the joysticks to a square region.
This is necessary to drive tight corners, and fast curves.
Expanded user interface on the game controller
Better and more complete comments.
Various small bug fixes.