Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(doc-15): add descriptions to Kittehub project table #42

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

pashafateev
Copy link
Contributor

I don’t think adding an additional column for features is necessary.

Here are some thoughts:

from doc-13

start various connection types, @autokitteh.activity, subscribe & next_event, python vs starlark, maybe you can think of a few more.

  • @autokitteh.activity: If we’re trying to minimize the use of autokitteh.activity, it doesn’t make sense to highlight it, especially since it's not a concept most users will immediately understand.

  • subscribe and next_event: As far as I know, these features aren’t present in Kittehub.

  • Python vs Starlark: If it's important to distinguish between Python and Starlark implementations, I suggest using an emoji with a legend for clarity. For example:

    Legend:

    ⭐️ - Implemented in Starlark
    🐍 - Implemented in Python

...
| 🐍 Data Pipeline |
| ⭐️ GitHub Copilot Seats |
| 🐍 Google Forms to Jira |
| 🐍 Jira Assignee From Calendar |
| 🐍 Jira to Google Calendar |
| ⭐️ Pull Request Review Reminder (Purrr) |
| ⭐️ ReviewKitteh |
| 🐍 Task Chain |

@pashafateev pashafateev requested review from itayd and daabr August 9, 2024 19:19
Copy link
Contributor

@daabr daabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your emoji suggestion! Please do that, and add a single-line legend under the table

@pashafateev pashafateev merged commit 59e2584 into main Aug 9, 2024
1 check passed
@pashafateev pashafateev deleted the pasha/doc-15 branch August 9, 2024 20:41
pashafateev added a commit that referenced this pull request Sep 3, 2024
I don’t think adding an additional column for features is necessary.

Here are some thoughts:

from
[doc-13](https://linear.app/autokitteh/issue/DOC-13/readmemd-for-kittehub-index-table-showing-what-each-project-does)
>start various connection types, `@autokitteh.activity`, subscribe &
next_event, python vs starlark, maybe you can think of a few more.

- **`@autokitteh.activity`:** If we’re trying to minimize the use of
`autokitteh.activity`, it doesn’t make sense to highlight it, especially
since it's not a concept most users will immediately understand.
- **`subscribe` and `next_event`:** As far as I know, these features
aren’t present in Kittehub.
- **Python vs Starlark:** If it's important to distinguish between
Python and Starlark implementations, I suggest using an emoji with a
legend for clarity. For example:

  ## Legend:
  ⭐️ - Implemented in Starlark  
  🐍 - Implemented in Python
  
...
| 🐍 [Data Pipeline](./data_pipeline/)                          |
| ⭐️ [GitHub Copilot Seats](./github_copilot/)                  |
| 🐍 [Google Forms to Jira](./google_forms_to_jira/)            |
| 🐍 [Jira Assignee From Calendar](./jira_assignee_from_calendar/) |
| 🐍 [Jira to Google Calendar](./jira_to_google_calendar/)      |
| ⭐️ [Pull Request Review Reminder (Purrr)](./purrr/)         |
| ⭐️ [ReviewKitteh](./reviewkitteh/)                           |
| 🐍 [Task Chain](./task_chain/)                                |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants