-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-1102: add new Google Forms to Jira demo #24
Conversation
### Potential improvements - Incorporate due date (calculate start date based on due date?) - Support markdown - Dynamic emails (currently using example.com) - Dynamic timezones --------- Co-authored-by: Daniel Abraham <[email protected]>
Co-authored-by: Daniel Abraham <[email protected]>
Co-authored-by: Daniel Abraham <[email protected]>
Co-authored-by: Daniel Abraham <[email protected]>
Related to this [PR](autokitteh/autokitteh#433) without which this code will not run. --------- Co-authored-by: Daniel Abraham <[email protected]>
### Blockers I was unable to complete my task. I had some final touches and then I started seeing errors although I didn't change the code. I decided to keep it as it was when it was last working. ### Unfinished tasks - Move constants to .yaml - Add filter by project ### Error logs [ak-server](https://github.com/user-attachments/files/16038831/output.txt) [ak-session](https://github.com/user-attachments/files/16038862/session.txt) --------- Co-authored-by: Daniel Abraham <[email protected]>
Not tested with real data - see https://docs.aws.amazon.com/health/latest/ug/health-api.html > You must have a Business, Enterprise On-Ramp, or Enterprise Support plan from [AWS Support](https://aws.amazon.com/premiumsupport/) to use the AWS Health API. If you call the AWS Health API from an AWS account that doesn't have a Business, Enterprise On-Ramp, or Enterprise Support plan, you receive a SubscriptionRequiredException error.
Co-authored-by: Daniel Abraham <[email protected]>
Co-authored-by: Daniel Abraham <[email protected]>
I generally kept the format the same, but I rephrased the benefits section slightly. I could repeat the same text for all of them, but I thought I'd switch it up a bit. --------- Co-authored-by: Daniel Abraham <[email protected]>
google_forms_to_jira/program.py
Outdated
total_responses = None | ||
while True: | ||
total_responses = _poll_forms(form_data, form_id, total_responses) | ||
time.sleep(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a configurable AK var for this constant value?
google_forms_to_jira/program.py
Outdated
|
||
def _create_jira_issue(title, response): | ||
jira = atlassian_jira_client("jira_connection") | ||
answers = json.dumps(response["answers"], indent=2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
google_forms_to_jira/program.py
Outdated
jira = atlassian_jira_client("jira_connection") | ||
answers = json.dumps(response["answers"], indent=2) | ||
fields = { | ||
"project": {"key": "<JIRA_PROJECT_KEY>"}, # Replace with your Jira project key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be a var
760c40d
to
9717330
Compare
I'm not sure this is necessary it just makes the description output cleaner
answers = json.dumps(response["answers"], indent=2)
example of description output is here