test: convert all unit tests to Pytest #151
Open
+367
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashafateev
reviewed
Jan 9, 2025
There was a problem hiding this comment.
The main feedback here is similar to the comments on the original PR itself. markdown_test.py doesn’t seem specifically related to purrr. It feels more appropriate to place it in the autokitteh repository rather than kittehub.
There was a problem hiding this comment.
Ack, in the separate PR. The unit tests will be the same either way.
daabr
force-pushed
the
daniel/int-171-pytest
branch
from
8b21f7a to
d295fac
Compare
daabr
force-pushed
the
daniel/int-171-pytest
branch
from
d295fac to
6b2396e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to use the
pytest-mockplugin instead of the built-inmonkeypatchwhich requires a lot more boilerplate in Purrr's tests.Refs: INT-171