Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing strictness #148

Merged
merged 3 commits into from
Jan 7, 2025
Merged

fix: typing strictness #148

merged 3 commits into from
Jan 7, 2025

Conversation

daabr
Copy link
Contributor

@daabr daabr commented Jan 7, 2025

A few random fixes for type-related warnings from Pylance in VS Code, when type checking mode is "standard" instead of the default "off". Not specific to any project or task, and not a complete fix of the repo, just a few low-hanging fruits.

Most common: str | None --> str in places where it's clear that None is not expected.

os.getenv("var name") --> os.getenv("var name") or "default value"

dict.get("key") --> dict.get("key", "default value")

Also a few import tweaks to fix false-positive type warnings.

aws_health_to_slack/program.py Show resolved Hide resolved
data_pipeline/pipeline.py Show resolved Hide resolved
purrr/users.py Show resolved Hide resolved
@daabr daabr merged commit e976311 into main Jan 7, 2025
4 checks passed
@daabr daabr deleted the daniel/fix-typing branch January 7, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants