ci: refresh settings and workflow #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daabr
commented
Jan 5, 2025
daabr
commented
- Enable unit testing (except in the Purrr project - those UT require AK context)
- Add various optional but important linters to Ruff
- Don't pin pytest and ruff versions, no point in updating it from time to time like in the AK repo
mario99logic
reviewed
Jan 6, 2025
| @@ -1,7 +1,7 @@ | |||
| # Add "test" once we have unit tests | |||
| all: deps format lint # test | |||
| all: deps lint format test | |||
There was a problem hiding this comment.
Is there a specific reason for changing the order between lint and format?
There was a problem hiding this comment.
Yes. It turns out that import sorting happens in the lint step, we I'm allowing the formatter to react to that. Other than that the order doesn't really matter either way.
Comment on lines
+1
to
+2
| pytest | ||
| ruff |
There was a problem hiding this comment.
Why did we remove the version constraint
There was a problem hiding this comment.
As I wrote in the PR description: no point in updating them from time to time like in the AK repo, we're OK with (and in fact prefer) always using the latest release
pashafateev
reviewed
Jan 6, 2025
pashafateev
approved these changes
Jan 7, 2025
daabr
added a commit
that referenced
this pull request
Jan 7, 2025
- Enable unit testing (except in the Purrr project - those UT require AK context) - Add various optional but important linters to Ruff - Don't pin pytest and ruff versions, no point in updating it from time to time like in the AK repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.