Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Add Relationship Index Storing Caveat #1988

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package migrations

import (
"context"

"github.com/jackc/pgx/v5"
)

const (
addRelationshipIndexStoringCaveatQuery = `
-- Drop existing indexes
DROP INDEX IF EXISTS ix_relation_tuple_by_subject;
DROP INDEX IF EXISTS ix_relation_tuple_by_subject_relation;

-- Create new indexes with the STORING clause
CREATE INDEX ix_relation_tuple_by_subject_storing_caveat
ON relation_tuple (userset_object_id, userset_namespace, userset_relation, namespace, relation)
STORING (caveat_name, caveat_context);

CREATE INDEX ix_relation_tuple_by_subject_relation_storing_caveat
ON relation_tuple (userset_namespace, userset_relation, namespace, relation)
STORING (caveat_name, caveat_context);
`
)

func init() {
err := CRDBMigrations.Register("add-relationship-index-storing-caveat", "add-relationship-counters-table", addRelationshipIndexStoringCaveat, noAtomicMigration)
if err != nil {
panic("failed to register migration: " + err.Error())
}
}

func addRelationshipIndexStoringCaveat(ctx context.Context, conn *pgx.Conn) error {
if _, err := conn.Exec(ctx, addRelationshipIndexStoringCaveatQuery); err != nil {
return err
}
return nil
}
Loading