crdb: fix watch error: %!s(<nil>) #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I identified some error reports in CRDB based clusters
that showed the following:
{
"level":"error",
"protocol":"grpc",
"grpc.component":"server",
"grpc.service":"authzed.api.v1.WatchService",
"grpc.method":"Watch",
"grpc.method_type":"server_stream",
"grpc.start_time":"2023-11-27T12:38:35Z",
"grpc.code":"Internal",
"grpc.error":"rpc error: code = Internal desc = watch error: %!s(<nil>)",
"grpc.time_ms":1030,
"time":"2023-11-27T12:38:36Z",
}
I could only identify one spot where a nil
error could be sent over the errors channel,
which would in turn cause SpiceDB response
to have gRPC error code "Internal".
If the sql.Rows return an error that isnt
cancellation, then it's possible that nil values
will be sent over the error channel.
GHSA-2c7c-3mj9-8fq
github-actions
bot
added
area/dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I identified some error reports in CRDB-based clusters that showed the following:
{ "level":"error", "protocol":"grpc", "grpc.component":"server", "grpc.service":"authzed.api.v1.WatchService", "grpc.method":"Watch", "grpc.method_type":"server_stream", "grpc.start_time":"2023-11-27T12:38:35Z", "grpc.code":"Internal", "grpc.error":"rpc error: code = Internal desc = watch error: %!s(<nil>)", "grpc.time_ms":1030, "time":"2023-11-27T12:38:36Z", }I could only identify one spot where a nil
error could be sent over the errors channel,
which would in turn cause SpiceDB response
to have the gRPC error code "Internal".
If the
sql.Rowsreturns an error that isntcancellation, then it's possible that nil values
will be sent over the error channel.