Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
I identified some error reports in CRDB based clusters that showed the following: { "level":"error", "protocol":"grpc", "grpc.component":"server", "grpc.service":"authzed.api.v1.WatchService", "grpc.method":"Watch", "grpc.method_type":"server_stream", "grpc.start_time":"2023-11-27T12:38:35Z", "grpc.code":"Internal", "grpc.error":"rpc error: code = Internal desc = watch error: %!s(<nil>)", "grpc.time_ms":1030, "time":"2023-11-27T12:38:36Z", } I could only identify one spot where a nil error could be sent over the errors channel, which would in turn cause SpiceDB response to have gRPC error code "Internal". If the sql.Rows return an error that isnt cancellation, then it's possible that nil values will be sent over the error channel.
- Loading branch information