Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom initContainers #208

Closed
wants to merge 2 commits into from

Conversation

hqdncw
Copy link
Contributor

@hqdncw hqdncw commented May 27, 2023

Description

Adding custom initialization containers gives users more fine-grained control over their deployments. Adding custom initContainers is possible in Bitnami charts as well.

One example use-case is ensuring that another service is available.

TODO

  • Add unit tests

@james-d-elliott
Copy link
Member

james-d-elliott commented May 28, 2023

Thanks for choosing to contribute! We don't currently unit test the charts as we have not invested time into that, you're welcome to skip it if you want. Otherwise we can probably assist with this if you have a particular unit testing tool you are familiar with.

One comment I'd add is I'm not too sure if it's better as is or better to limit the rendering to the elements that exist within the spec, rather than just arbitrarily rendering values the user adds. There are benefits to both (i.e. one shows an error the other silently ignores it).

Also you'll need to sign the DCO: https://www.authelia.com/contributing/guidelines/commit-message/#developer-certificate-of-origin

@hqdncw hqdncw force-pushed the feature/init-containers branch from ea77629 to d790411 Compare May 29, 2023 08:12
@ajgon
Copy link

ajgon commented Jul 2, 2023

Hey @uid54289 , thank you very much for this. Since, you're implementing this - can you also add support for sidecar containers as well? These can be super-handy for tools like k8s-sidecars.

@thomaspetit
Copy link

Any update on this feature? :) Might wanna look into it myself as I want to be able to create users_database.yml file (bounded to a PVC).

@james-d-elliott
Copy link
Member

Taken over in #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants