.buildkite/hooks/pre-command (1)

Line range hint 12-19: Consider adding a safety check before using rm -rf to avoid accidental deletion of important data.

+ if [[ -d ".cr-release-packages" || -d ".cr-index" ]]; then
    rm -rf .cr-release-packages .cr-index
+ fi

charts/authelia/templates/_helpers.tpl (1)

479-490: LGTM! Consider adding input validation.

The new template rendering helper is well-structured and handles both string and non-string values appropriately. Consider these improvements:

 {{- define "authelia.snippets.render" -}}
+    {{- if not .value -}}
+        {{- fail "Value parameter is required for authelia.snippets.render" -}}
+    {{- end -}}
+    {{- if not .context -}}
+        {{- fail "Context parameter is required for authelia.snippets.render" -}}
+    {{- end -}}
     {{- if typeIs "string" .value }}
         {{- tpl .value .context }}
     {{- else }}
         {{- tpl (.value | toYaml) .context }}
     {{- end }}
 {{- end -}}

charts/authelia/README.md (1)

Line range hint 1-300: Documentation missing for recent changes.

The README needs to be updated to reflect two significant changes mentioned in the PR:

1. The behavior change regarding stateful value when using file backend with watch option enabled
2. The new template rendering function (authelia.snippets.render)

Consider adding these details in appropriate sections:

• Add information about the stateful behavior in the "Breaking Changes" or "Expected Minimum Configuration" sections
• Document the new template rendering function in a relevant section

Would you like me to help draft the documentation for these changes?

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Verify the stateful condition affects pod replicas correctly
# Test cases:
# 1. File backend with watch enabled
# 2. File backend with watch disabled
# 3. LDAP backend enabled

# Search for usage of the stateful helper in pod/deployment templates
rg -l "authelia.stateful" charts/authelia/templates/

# Search for replica configurations
rg -l "replicas:" charts/authelia/templates/

#!/bin/bash
# Let's examine how the stateful condition is used in deployment.yaml
rg -B 2 -A 2 "authelia.stateful" charts/authelia/templates/deployment.yaml

# Also check the deployment.yaml for replica configuration
rg -B 2 -A 2 "replicas:" charts/authelia/templates/deployment.yaml

# Let's see the complete stateful helper function for context
rg -B 5 -A 5 "authelia.stateful" charts/authelia/templates/_helpers.tpl

#!/bin/bash
# Description: Search for related documentation and examples

# Check for any existing documentation about file backend watch option
echo "Searching for file backend watch documentation..."
rg -i "file.*watch" --type md

# Check for examples in values files
echo "Checking values files for examples..."
fd -e yaml -e yml values | xargs rg -i "file.*watch"

# Check for any breaking changes documentation
echo "Checking for breaking changes documentation..."
rg -i "breaking.*changes" --type md

#!/bin/bash
# Check the content of BREAKING.md
echo "Checking BREAKING.md content..."
cat charts/authelia/BREAKING.md

# Check for any stateful configuration examples
echo -e "\nChecking for stateful configuration examples..."
rg -i "stateful" --type yaml --type md

charts/authelia/templates/_helpers.tpl (1)

64-64: Consider improving readability of the complex condition.

While the logic is correct and aligns with the PR objectives, the condition could be more readable.

Consider breaking down the condition into smaller parts:

-            {{- else if or (not .Values.configMap.authentication_backend) (not .Values.configMap.authentication_backend.ldap.enabled) (and .Values.configMap.authentication_backend.file.enabled (not .Values.configMap.authentication_backend.file.watch)) -}}
+            {{- else if or (not .Values.configMap.authentication_backend) -}}
+                {{- true -}}
+            {{- else if not .Values.configMap.authentication_backend.ldap.enabled -}}
+                {{- true -}}
+            {{- else if and .Values.configMap.authentication_backend.file.enabled (not .Values.configMap.authentication_backend.file.watch) -}}
+                {{- true -}}

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Verify the usage and impact of the changes

# Test 1: Check for usage of the new render function
echo "Checking for usage of authelia.snippets.render..."
rg "authelia\.snippets\.render" --type yaml

# Test 2: Check for potential replica configurations
echo "Checking for replica configurations..."
rg "replicas:" --type yaml -B 5 -A 5

# Test 3: Check for file backend configurations
echo "Checking for file backend configurations..."
rg "authentication_backend:\s*\n\s*file:" --type yaml -B 5 -A 5

#!/bin/bash
# Let's try a different approach to verify the changes

# Check for file backend configurations with multiline flag
echo "Checking for file backend configurations..."
rg -U "authentication_backend:(\n|\s)*file:" --type yaml -B 5 -A 5

# Check the helpers template content
echo "Checking the helpers template content..."
cat charts/authelia/templates/_helpers.tpl

# Check for statefulset configurations
echo "Checking for statefulset configurations..."
rg "kind:\s*StatefulSet" --type yaml -B 5 -A 5

charts/authelia/templates/_helpers.tpl (1)

479-491: Consider adding error handling to the template render function.

While the implementation is functional, it could benefit from additional robustness:

1. Add error handling for invalid templates
2. Validate the context parameter
3. Add nil checks for the value parameter

Consider this enhanced implementation:

 {{- define "authelia.snippets.render" -}}
+    {{- if not .context }}
+        {{- fail "Context parameter is required for authelia.snippets.render" }}
+    {{- end }}
+    {{- if not .value }}
+        {{- dict | toYaml }}
+    {{- else }}
     {{- if typeIs "string" .value }}
         {{- tpl .value .context }}
     {{- else }}
         {{- tpl (.value | toYaml) .context }}
     {{- end }}
+    {{- end }}
 {{- end -}}

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Verify the stateful condition handles various authentication backend configurations correctly.

# Test 1: Search for usage of authentication_backend.file.watch in the codebase
echo "Test 1: Verify file.watch usage"
rg "authentication_backend.file.watch" -A 5

# Test 2: Search for deployment configurations that might be affected
echo "Test 2: Check deployment configurations"
rg "replicas:|authentication_backend:" -A 5

#!/bin/bash
# Check file backend configuration and its watch option
echo "Test 1: Check file backend configuration in values and templates"
rg "file:|watch:" -A 3 charts/authelia/values.yaml charts/authelia/templates/configMap.yaml

# Check the complete authentication backend template logic
echo "Test 2: Check complete authentication backend template section"
rg "authentication_backend:" -B 5 -A 15 charts/authelia/templates/configMap.yaml

# Check if there are any other conditions related to stateful/replicas
echo "Test 3: Check other stateful conditions"
rg "stateful|replicas" charts/authelia/templates/_helpers.tpl

charts/authelia/templates/_helpers.tpl (2)

64-64: LGTM! Consider improving readability.

The condition correctly implements the requirement to set stateful to false when using file backend with watch enabled. However, the complex nested condition could be split for better readability.

Consider refactoring the condition for better readability:

-            {{- else if or (not .Values.configMap.authentication_backend) (not .Values.configMap.authentication_backend.ldap.enabled) (and .Values.configMap.authentication_backend.file.enabled (not .Values.configMap.authentication_backend.file.watch)) -}}
+            {{- else if or (not .Values.configMap.authentication_backend) -}}
+                {{- true -}}
+            {{- else if not .Values.configMap.authentication_backend.ldap.enabled -}}
+                {{- true -}}
+            {{- else if and .Values.configMap.authentication_backend.file.enabled (not .Values.configMap.authentication_backend.file.watch) -}}
                {{- true -}}

---

Line range hint 479-486: LGTM! Consider adding input validation.

The new helper function correctly handles both string and non-string values for template rendering. However, it could benefit from input validation.

Consider adding validation for required parameters:

 {{- define "authelia.snippets.render" -}}
+    {{- if not .value -}}
+        {{- fail "value parameter is required for authelia.snippets.render" -}}
+    {{- end -}}
+    {{- if not .context -}}
+        {{- fail "context parameter is required for authelia.snippets.render" -}}
+    {{- end -}}
     {{- if typeIs "string" .value }}
         {{- tpl .value .context }}
     {{- else }}
         {{- tpl (.value | toYaml) .context }}
     {{- end }}
 {{- end -}}

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Description: Check usage patterns of the new features

# Test 1: Check for potential uses of the new render function
echo "Checking for potential template rendering patterns..."
rg --type yaml --type go "tpl.*toYaml|toYaml.*tpl" ./charts

# Test 2: Check for configurations that might be affected by the stateful changes
echo "Checking for file backend configurations..."
rg --type yaml "authentication_backend:.*file:" ./charts

#!/bin/bash
# Let's try a different approach to verify the changes

# Check the template context and usage
echo "Checking the helper template usage and context..."
rg -A 5 -B 5 "authentication_backend" ./charts/authelia/templates/

# Check for file backend related configurations in values
echo "Checking values and configurations..."
cat ./charts/authelia/values.yaml | grep -A 10 "authentication_backend:"

# Check for any stateful set definitions that might be affected
echo "Checking statefulset configurations..."
rg -A 5 "kind:\s+StatefulSet" ./charts/authelia/templates/