Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SFSafariViewController #800

Merged
merged 31 commits into from
Nov 28, 2023
Merged

Conversation

poovamraj
Copy link
Contributor

@poovamraj poovamraj commented Nov 10, 2023

Changes

We have added support for SFSafariViewController through useSFSafariViewController.

The WebAuthentication.resume(with: value) required to continue the authentication will be listened through Linking.addEventListener

References

We have had internal requests to support SFSafariViewController

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

ios/A0Auth0.m Outdated Show resolved Hide resolved
ios/NativeBridge.swift Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
Co-authored-by: Rita Zerrizuela <[email protected]>
src/webauth/agent.ts Outdated Show resolved Hide resolved
src/webauth/agent.ts Outdated Show resolved Hide resolved
@poovamraj poovamraj merged commit 42783ac into master Nov 28, 2023
8 checks passed
@poovamraj poovamraj deleted the support-sfsafariviewcontroller branch November 28, 2023 15:09
@poovamraj poovamraj mentioned this pull request Dec 5, 2023
@guhcostan-tw
Copy link

guhcostan-tw commented Dec 19, 2023

@poovamraj You guys did the login, but logout does not disconnect from SSO :(

Can you do the logout now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants