Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Re-add node-polyfill to frontend bundle #401

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

sauntimo
Copy link
Contributor

✏️ Changes

  • I removed the node polyfill from the frontend bundle as it seemed that the crypto and stream modules it was added to replace weren't actually being used on the frontend. However, whilst they aren't used directly, they are used indirectly. So, I'm adding it back in. This does increase the size of the ui.js file to about 1.8mb however this is okay and should be deployed just fine.

🔗 References

  • n/a

🎯 Testing

  • ✅ 40/40 integration tests passing against a layer0 dev space
  • ✅ 145/145 unit tests passing locally
  • ✅ tested in iam-authz-extensionupgrade2 space manually with demozero

🚀 Deployment

✅ This can be deployed any time

🎡 Rollout

In order to verify that the deployment was successful we will test in a prod space both before and after we make this version available to customers.

🔥 Rollback

If there are issues with this version we will follow the disaster recovery plan for the authz extension.

@sauntimo sauntimo marked this pull request as ready for review January 14, 2025 13:17
@sauntimo sauntimo merged commit 74522d5 into master Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants