feat: erc20 statistic (total holder) #777
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| .select( | ||
| 'erc20_contract.id as erc20_contract_id', | ||
| knex.raw( | ||
| 'count(CASE when holders.amount > 0 THEN 1 ELSE null END) as count' |
There was a problem hiding this comment.
'(holders.amount > 0)::int as count' đc ko?
src/services/evm/erc20.service.ts
Outdated
| } | ||
|
|
||
| async handleTotalHolderStatistic(systemDate: Date) { | ||
| const totalHolder = await Erc20Contract.query() |
src/services/evm/erc20.service.ts
Outdated
| .first() | ||
| .throwIfNotFound() | ||
| ).time; | ||
| const lastUpdatedDate = (await Erc20Statistic.query().max('date').first()) |
There was a problem hiding this comment.
ko viết await như này, khó đọc mà cũng ko có xử lý lỗi
| if (lastUpdatedDate) { | ||
| systemDate.setHours(0, 0, 0, 0); | ||
| lastUpdatedDate.setHours(0, 0, 0, 0); | ||
| if (systemDate > lastUpdatedDate) { |
There was a problem hiding this comment.
gộp 2 câu if điều kiện chạy lại
if (!lastUpdatedDate || systemDate > lastUpdatedDate)
There was a problem hiding this comment.
Đoạn này em đang check xem là ngày dd/mm/yy (tại thời điểm 0h0p0s) đã thống kê trong DB chưa. Vì mỗi 6s/block nên phải chuyển timestamp về ngày để so sánh đảm bảo 1 ngày 1 thống kê
No description provided.