-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: update ruff and codespell versions #113
Conversation
Reviewer's Guide by SourceryThis PR updates the versions of two pre-commit hooks (ruff and codespell) and fixes type checking issues in the codebase. The ruff version is updated from v0.1.8 to v0.7.0, and codespell is updated from v2.2.4 to v2.3.0. Additionally, two type-related comparisons are modified to use more appropriate comparison methods. Class diagram for updated type checking in parameter.pyclassDiagram
class Parameter {
- description: String
- value_type: Any
}
class CommandLineParser {
+ add_argument(name: String, action: String)
}
Parameter --> CommandLineParser : uses
note for Parameter "Updated type check for value_type to use isinstance"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Update
ruff
andcodespell
pre-commits to the versions we now use in other packages.Summary by Sourcery
Update pre-commit hooks for ruff and codespell to newer versions and fix type comparison issues in the codebase.
Bug Fixes:
Enhancements: