Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for Python 3.13 #185

wants to merge 1 commit into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 16, 2024

Adds Python 3.13 as supported version to the Python package and enables tests for it in Ubuntu runners.

Summary by Sourcery

Add support for Python 3.13 by updating the project configuration and enabling CI tests for this version on Ubuntu runners.

Enhancements:

  • Add support for Python 3.13 in the project configuration.

CI:

  • Enable testing for Python 3.13 on Ubuntu runners.

Copy link

sourcery-ai bot commented Dec 16, 2024

Reviewer's Guide by Sourcery

This PR adds Python 3.13 support by updating the CI workflow configuration and package metadata. The changes are straightforward, only requiring additions to version lists in configuration files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add Python 3.13 to the CI workflow matrix
  • Added '3.13' to the python-version matrix array for testing across all supported operating systems
.github/workflows/test.yml
Update package metadata to declare Python 3.13 support
  • Added Python 3.13 classifier to the package classifiers list
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Adding support for Python 3.13 seems premature as it's still in development and not yet released. Consider waiting until at least an alpha/beta release is available to avoid potential compatibility issues with the final release.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw
Copy link
Member Author

hagenw commented Dec 16, 2024

This is currently blocked until numba 0.61 is released, see numba/numba#9413.

numba is a dependency of librosa, which we use as an example in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant