Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repositories argument to audb.available() #489

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 12, 2024

Add repositories argument to audb.available() to be able to limit the repositories, in which it should search. Before, a user needed to modify audb.confg.REPOSITORIES before calling audb.available() to limit its output to certain repositories.

image

Summary by Sourcery

Add a 'repositories' argument to the audb.available() function to enable users to limit the search to specified repositories, enhancing the function's flexibility and usability.

New Features:

  • Introduce a 'repositories' argument to the audb.available() function, allowing users to specify which repositories to search.

Tests:

  • Add tests for the new 'repositories' argument in audb.available(), including scenarios for all repositories and single repository searches.

This comment was marked as outdated.

sourcery-ai[bot]

This comment was marked as outdated.

@hagenw hagenw force-pushed the available-repositories branch from db9e6eb to 8d46aaa Compare December 15, 2024 09:29
@hagenw
Copy link
Member Author

hagenw commented Dec 15, 2024

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

audb/core/api.py Show resolved Hide resolved
tests/test_api.py Outdated Show resolved Hide resolved
tests/test_api.py Outdated Show resolved Hide resolved
tests/test_api.py Outdated Show resolved Hide resolved
audb/core/api.py Outdated Show resolved Hide resolved
@ChristianGeng ChristianGeng self-requested a review December 16, 2024 12:16
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the issues that I had
(typing related and a more explicit docstring) are settled.

Proceeding with approval.

@hagenw hagenw merged commit a3e9832 into main Dec 16, 2024
10 checks passed
@hagenw hagenw deleted the available-repositories branch December 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants