-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: enable tests for documentation files #478
Conversation
Reviewer's Guide by SourceryThis PR adds a conftest.py file to the docs directory to enable doctests using the sybil library. The implementation configures different test fixtures and Sybil instances to handle various documentation files with specific testing requirements. Class diagram for the new conftest.py setupclassDiagram
class Sybil {
+DocTestParser[] parsers
+String[] filenames
+String[] fixtures
+Function setup
}
class Pytest {
+Fixture run_in_tmpdir
+Fixture default_configuration
}
class AudbConfig {
+String CACHE_ROOT
+String SHARED_CACHE_ROOT
+Repository[] REPOSITORIES
}
class Repository {
+String name
+String host
+String backend
}
Sybil --> Pytest : uses
Pytest --> AudbConfig : modifies
AudbConfig --> Repository : contains
note for Sybil "Sybil instances are configured for different documentation files with specific fixtures."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
In #469 we switched to use
sybil
for doctests, but we forgot to pushdocs/conftest.py
to include the documentation files as well. This is fixed by this pull request.Summary by Sourcery
Tests: