Rewrite FAT makefile as snippet #144
Open
+250
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wom-bat
requested changes
Jan 9, 2025
| mkdir -p fat/ff15 | ||
|
|
||
| fat/ff15/%.o: CFLAGS += $(FAT_CFLAGS) | ||
| fat/ff15/%.o: $(FAT_FF15_SRC_DIR)/%.c $(FAT_LIBC_INCLUDE) $(CHECK_FAT_FLAGS_MD5) |fat/ff15 |
There was a problem hiding this comment.
FAT_LIBC_INCLUDE is undefined -- I don't think it's needed in the dependencies, as it's not going to change. The .d files will pick up changed files.
There was a problem hiding this comment.
FAT_LIBC_INCLUDE is supposed to be defined by the includer. In the case of musllibc, the include files are generated, so musllibc needs to be built before they exist, which is why I added it as a dependency.
JE-Archer
force-pushed
the
fat_make_snippet
branch
2 times, most recently
from
b1218c0 to
45841d7
Compare
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
JE-Archer
force-pushed
the
fat_make_snippet
branch
from
45841d7 to
96780fe
Compare
Signed-off-by: James Archer <[email protected]>
Signed-off-by: James Archer <[email protected]>
JE-Archer
force-pushed
the
fat_make_snippet
branch
from
96780fe to
2ffe913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.