Unbitrot vmm LionsOS example #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this requires a minor sddf change to get the libsddf_util_debug.a dependency tracked for serial/virt.elf and uart_driver.elf |
|
Two more things that come to mind:
|
Sure. I'd keep the README here too though, for quick reference. |
|
They will quickly diverge though, I'd rather not duplicate it. |
wom-bat
force-pushed
the
fix-vmm-example
branch
from
4e5f5d6 to
0d5fb0e
Compare
|
So the two Linux runs worked, but the MacOSX one did not. |
|
They'll use GNU Make I believe. This is the error message on macOS: |
|
Looks like the invocation of |
It;s invoked in GNUMake uses |
-- Ported the console serial system to current sDDF -- Updated system files for current microkit -- Updated README.md to match system -- Allow local user replacement of linux and initrd to match local (passed-through) filesystem Signed-off-by: Peter Chubb <[email protected]>
Signed-off-by: Peter Chubb <[email protected]>
The linux and initrd image for the VMM example are inserted from the user's system, and should not be saved in git. Signed-off-by: Peter Chubb <[email protected]>
The VMM example changes need the update uart_driver.mk and serial components make snippets. Signed-Off-By: Peter Chubb <[email protected]>
Signed-off-by: Peter Chubb <[email protected]>
wom-bat
force-pushed
the
fix-vmm-example
branch
from
22ead3f to
b297ba3
Compare
Comment on lines
+5
to
+6
| examples/vmm/vmm/initrd.img | ||
| examples/vmm/vmm/linux |
There was a problem hiding this comment.
This shouldn't be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Ported the console serial system to current sDDF -- Updated system files for current microkit
-- Updated README.md to match system
-- Allow local user replacement of linux and initrd to match local
(passed-through) filesystem