Skip to content

Commit

Permalink
[Fixes #34] Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
michalfita committed Oct 18, 2022
1 parent 0fa381e commit ef274b9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

- [Sealed](https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed) all HAL-internal traits to disallow potentially unsound downstream trait implementations.
- Regenerated PACs with `svd2rust 0.25.1` using up-to-date (2022-05-18) SVDs. These SVDs are now vendored in this repository, instead of using a submodule.
- Cargo Workspace sorted, so local builds and crate publictions work.
- Cargo Workspace sorted, so local builds and crate publications work.
- Updates to `update-pacs.sh` script, moved to tools.

### Removed
Expand Down
2 changes: 0 additions & 2 deletions tools/update-pacs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ for svd in svd/*.svd; do
mkdir -p $pac
pushd $pac

#sed -e "s|\${crate}|${crate}|g" -e "s|\${chip}|${chip}|g" -e "s|\${pac}|${pac}|g" -e "s|\${version}|${version}|g" "${top}/pac/templates/Cargo.toml.template" > Cargo.toml
#sed -e "s|\${crate}|${crate}|g" -e "s|\${chip}|${chip}|g" -e "s|\${pac}|${pac}|g" -e "s|\${version}|${version}|g" "${top}/pac/templates/README.md.template" > README.md
expand Cargo.toml
expand README.md

Expand Down

0 comments on commit ef274b9

Please sign in to comment.