Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MCPC+ and other general errors #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thecodewarrior
Copy link
Collaborator

Added particle effect when entering a portal
Added a Not enough XP message
Added Wait time config
fixed Yaml error in local-EM.yml
Added onBlockPlace cool down so there aren't double block place events on MCPC+
Fixed setPirvacy Stack Overflow Error
Made portal name regex prettier
Removed Dependency on CraftWorld
Subtracts XP only if there is a destination for a portal
Fixed cast of Object to int

Added particle effect when entering a portal, Added a Not enough XP
message, Added Wait time config, fixed Yaml error in local-EM.yml,
Added onBlockPlace cool down so there aren't double block place events
on MCPC+, Fixed setPirvacy Stack Overflow Error, made portal name regex
prettier, Removed Dependency on CraftWorld, Subtracts XP only if there
is a destination for a portal, Fixed cast of Object to int
@atesin
Copy link
Owner

atesin commented Sep 19, 2014

thanks ... i will see these patches :)

afaik cannot remove CraftWorld dependency as it is used to self light red lamp blocks

i am afraid i am started to lose interest in this project, with the notice craftbukkit was owned by mojang, and moreover with the notice microsoft bought mojang :( .. do you like this plugin?

@thecodewarrior
Copy link
Collaborator Author

I tested it and it worked. (Then again, I didn't cause any block updates.) Is CraftWorld used to set a block to not update? I couldn't find any docs on CraftWorld online, so I just removed it and checked to see if it worked.

And yes, I think craftbukkit being claimed by mojang stinks. It's mojang who wrote their game in Java after all, the most de-compilable programming language I know of. So anybody really can get every last scrap of their source code. I can't see what the point is of restricting the source code of a easily de-compilable, freely downloadable piece of software.

And Minecraft being owned by mojang. Well, I think it might actually be good, putting some big money behind it, and hopefully they will make their own modding API, one that doesn't take months upon months to update to the latest version of Minecraft. And as one article I read says, it will free up Notch's mind to do other great things.

As for do I like the plugin? I love it, It's the simplest portal plugin I found. And the only one that isn't super over powered.

@atesin
Copy link
Owner

atesin commented Sep 22, 2014

thank you for your kind comments

i think you may wanted to say "And Minecraft being owned by MICROSOFT..."

i dont have a good feeling about these really (bukkit owned by mojang and mojang owned by microsoft) ... i think probably they view minecraft (and now bukkit as well) as a chance to get money as always do .. restricting the software even more or killing it (the competitor) to sell their own ideas .... anyway we hope that doesnt happen

i tried to write this plugin as many intuitive and similar to nether portals .. nether portals does not show any message on console, but maybe could be good in some specific cases

for the craftworld thing you can view how "lampcontrol" plugin works, and this thread http://forums.bukkit.org/threads/toggling-redstone-lamps.173286/ .. in addition i found when you set a red lamp on fire, it causes a short redstone pulse that shut the lamp off when it gone .... i did many tests and the only that worked was that craftworld one, maybe you can save that craftworld technique by modifying redstone current inside redlamp portal blocks also

would you like to take charge of this plugin?

@thecodewarrior
Copy link
Collaborator Author

You're welcome.

Yes, That is what I meant.

Yeah, I read up some more on the whole bukkit situation, and it doesn't look good. As for Minecraft being owned by Microsoft, I'm crossing all my fingers (and toes), hoping that they don't screw this up.

You definitely succeeded at making it the most intuitive portal plugin out there.

Hmm. I'll have to do some more testing, but I still don't understand exactly what isStatic does. I guess I'll have to do a little more research.

As for taking charge of the plugin. I would be happy to.

@atesin
Copy link
Owner

atesin commented Sep 22, 2014

i would prefer instead of displaying a message "you are out of xp points" , showing a visual (and/or sound) notification, for example a flash effects of some color or a grumpy sound.. something similar to an existent situation in vanilla minecraft (and therefore intuitive) (when you are enchanting something and run out of xp .. i dont know)

besides making a intuitive portal plugin i also want to be POPULAR xD (and optimal)

i think isStatic may stands for "immutable" or "locked", "unmodifiable by direct editing or unnatural ways", dunno

i see currently you are more motivated than me ... by "take charge of this plugin" i mean "give you access to everything so you can also easily (continue?) develop" .... tell me what you need to give you access on each section , my mail is atesin#gmail,com

forgive my awful english .. i am chilean

@thecodewarrior
Copy link
Collaborator Author

Ok, I thought that was what isStatic did, but I wasn't sure. I'll contact you with what I need.

Fixed Pistons not breaking portals
Not enough Exp now plays sound
Right clicking a portal base with a compass points it to the
destination portal
Shift right clicking with a compass resets it to the spawn point
Repository owner locked and limited conversation to collaborators Sep 23, 2014
Repository owner unlocked this conversation Sep 23, 2014
@atesin
Copy link
Owner

atesin commented Oct 27, 2022

hi... i know this is a really old thread

are you still interested in take the lead of this project??... have you checked my repos?, i have other cool plugins also... for example take a look to the continuation of this plugin, is even more user friendly

https://dev.bukkit.org/projects/world-portals-ng

this is one of the plugins i like most... i also have plugins for browse crafting recipes ingame, to send mail ingame between players, with item attachment support, to display chat bubbles over player heads, to sort chests, to push blocks inside hoppers, to make your armor "invisible" and presume your skin, some tools, etc..

https://dev.bukkit.org/members/atesin_dj/projects

a plugin that i always liked to write is some one similar to old "noPillars", that detects when players are building vertical 1x1 pillars and make them collapse at certain height... noPillars was really simple, i wanted to put some physics in this new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants