#173: Deprecating endpoint mapping in favor of plain middleware #174
Conversation
|
@VisualBean @yurvon-screamo are either of you familiar with aspnetcore? I haven't kept up to date with the recent changes to endpoints vs middleware. |
| AsyncApiSchema.v2.AsyncApiDocument asyncApiSchema, | ||
| IAsyncApiDocumentSerializer asyncApiDocumentSerializer) | ||
| { | ||
| var asyncApiSchemaJson = asyncApiDocumentSerializer.Serialize(asyncApiSchema); |
There was a problem hiding this comment.
This could be cached instead of serialising every time
There was a problem hiding this comment.
My apologies but that's what's been used all the time. That's not what this PR is about. It's about enabling others to use plain middlewares in order to be less limited.
That being said, thanks for your review.
Middleware structure looks fine. This could definitely also use some integration test. If we don't have the we application factory thing yet, we can get that added to the to-do |
|
I disagree with internal sealed middleware. Overloading or single usage are real scenarios. |
|
I agree with @VisualBean that the project would benefit from caching but let's track that via: #198 |
|
due to the lack of understanding of the benefits to the project from this change and any activities related to it, I close the request |
see #173