refactor: change expression check to option chain #801
Conversation
syedzubeen
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@syedzubeen Thanks for the PR. When you contribute to any project, especially open source, you should open a PR only once you are familiarized with contributing guide like https://github.com/asyncapi/asyncapi-react/blob/master/CONTRIBUTING.md
|
syedzubeen
changed the title
|
@derberg my bad. Should've gone through it first. |
There was a problem hiding this comment.
left one small comment
please, if you can, also open a separate PR to fix the contrib guide with proper links
- https://github.com/asyncapi/asyncapi-react/blob/master/docs/development/guide.md#naming-and-architecture-convention
- https://github.com/asyncapi/asyncapi-react/blob/master/docs/development/guide.md#project-structure
thanks for pointing it out
|
Kudos, SonarCloud Quality Gate passed!
|
|
looks like already solved with #812 |
Description
Changed the expression to an optional chain
Related issue(s)
Fixes #784