Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit tests out of texar #301

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Move unit tests out of texar #301

merged 2 commits into from
Feb 26, 2020

Conversation

gpengzhi
Copy link
Collaborator

resolve comments in #299

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #301 into master will decrease coverage by 2.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   82.46%   79.80%   -2.66%     
==========================================
  Files         207      132      -75     
  Lines       16050    11041    -5009     
==========================================
- Hits        13235     8811    -4424     
+ Misses       2815     2230     -585     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9683f...1e4416f. Read the comment docs.

@gpengzhi
Copy link
Collaborator Author

CI failed due to more than one percent drop in code coverage.

@gpengzhi gpengzhi merged commit b29cc54 into asyml:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants