Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcase for processor import check #54

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jzpang
Copy link
Collaborator

@jzpang jzpang commented Jun 12, 2021

This PR fixes #53.

Description of changes

testcase added for
elastic_search_index_processor.py
elastic_search_processor.py
elastic_search_query_creator.py
twittersearch_processor.py

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

Describe what test cases are included for the PR.

@jzpang jzpang requested a review from hunterhector June 12, 2021 05:20
@jzpang jzpang self-assigned this Jun 12, 2021
Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ask about the import check, it was on the composable system module (https://github.com/petuum/composing_information_system)

We need to maintain the wrapper repo as a higher standard. We need to write a bit more than just import. Can you add simple running examples here?

btw, what is the my_test.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testcase for import check
2 participants