-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints #593
Open
vandalt
wants to merge
11
commits into
astropy:main
Choose a base branch
from
vandalt:type-hints-no-annotations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add type hints #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not play nicely with `quantity_input` and Union type hints. Not necessary to provide basic type hint (LSP and static checks). See astropy/astropy#17017 for more info
typing.Self was introduced in 3.11. Use a custom TypeVar for older releases.
I updated formatting so that flake8 check would pass. I also patched the Currently the tests for Python 3.7 are failing because I used types with subscripts (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This adds type hints and fixes #592.
For astropy quantities, I used
Quantity
without any physical type or units annotations. The reasons are:Union
with non-Quantity types (seeunits.quantity_input
with annotatedQuantity
type hint in aUnion
causes error astropy#17017)The tests are all passing on my machine.
I was not sure what the formatting guidelines were for this package. Let me know if there are issues on that side!