-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote_data on all tests that require network #572
Changes from 4 commits
f4c1b76
abd7ce3
1d108ae
9944a3b
77d6477
c810cf8
c104da4
020efa9
11ccc0a
6d4d05e
2fa1f42
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,13 +79,13 @@ class FixedTarget(Target): | |
>>> from astropy.coordinates import SkyCoord | ||
>>> import astropy.units as u | ||
>>> sirius_coord = SkyCoord(ra=101.28715533*u.deg, dec=16.71611586*u.deg) | ||
>>> sirius = FixedTarget(coord=sirius_coord, name="Sirius") | ||
>>> sirius = FixedTarget(coord=sirius_coord, name="Sirius") # doctest: +REMOTE_DATA | ||
|
||
Create an equivalent `~astroplan.FixedTarget` object for Sirius by querying | ||
for the coordinates of Sirius by name: | ||
|
||
>>> from astroplan import FixedTarget | ||
>>> sirius = FixedTarget.from_name("Sirius") | ||
>>> sirius = FixedTarget.from_name("Sirius") # doctest: +REMOTE_DATA | ||
""" | ||
|
||
def __init__(self, coord, name=None, **kwargs): | ||
|
@@ -127,7 +127,7 @@ def from_name(cls, query_name, name=None, **kwargs): | |
Examples | ||
-------- | ||
>>> from astroplan import FixedTarget | ||
>>> sirius = FixedTarget.from_name("Sirius") | ||
>>> sirius = FixedTarget.from_name("Sirius") # doctest: +REMOTE_DATA | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Problem with marking lines with remote data, you also need to mark all the subsequent lines derived from here onwards. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, there are some tests where I should mark also the next line There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have also noticed that I was using REMOTE_DATA in some tests that don't need it. I have removed them |
||
>>> sirius.coord # doctest: +FLOAT_CMP | ||
<SkyCoord (ICRS): (ra, dec) in deg | ||
( 101.28715533, -16.71611586)> | ||
|
@@ -149,7 +149,7 @@ def __repr__(self): | |
>>> from astroplan import FixedTarget | ||
>>> from astropy.coordinates import SkyCoord | ||
>>> vega_coord = SkyCoord(ra='279.23473479d', dec='38.78368896d') | ||
>>> vega = FixedTarget(coord=vega_coord, name="Vega") | ||
>>> vega = FixedTarget(coord=vega_coord, name="Vega") # doctest: +REMOTE_DATA | ||
>>> print(vega) # doctest: +FLOAT_CMP | ||
<FixedTarget "Vega" at SkyCoord (ICRS): (ra, dec) in deg ( 279.23473479, 38.78368894)> | ||
""" | ||
|
pllim marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
subaru
needed here at all? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true, that variable is not used