Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit build #277

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

scikit build #277

wants to merge 1 commit into from

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@delucchi-cmu delucchi-cmu marked this pull request as draft May 24, 2024 19:18
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (5fdc4f6) to head (15b2ab2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          56       56           
  Lines        1967     1967           
=======================================
  Hits         1853     1853           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [5fdc4f6] <v0.3.3> After [e78382a] Ratio Benchmark (Parameter)
76.8±0.3ms 77.2±3ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
19.6±0.5ms 19.6±0.5ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
76.5±0.2ms 76.6±0.3ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
366±4ms 366±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
123±0.4ms 123±1ms 1 benchmarks.time_test_alignment_even_sky
13.4±0.1ms 13.4±0.02ms 0.99 benchmarks.time_test_cone_filter_multiple_order
84.3±2ms 82.4±3ms 0.98 benchmarks.Suite.time_paths_creation
13.3±0.1ms 12.9±0.2ms 0.97 benchmarks.Suite.time_inner_pixel_alignment
41.9±1ms 40.1±2ms 0.96 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant