Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address a handful of mypy warnings. #119

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Address a handful of mypy warnings. #119

merged 2 commits into from
Aug 7, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Code health improvement. Adds a few type annotations, and black formats the effected files.

This is related to issue #61, but does not fully resolve it. I just felt like poking around.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

smcguire-cmu
smcguire-cmu approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@delucchi-cmu delucchi-cmu merged commit dd0f29a into main Aug 7, 2023
8 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/61/mypy branch August 7, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcguire-cmu smcguire-cmu smcguire-cmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @smcguire-cmu