Clean up test data generation

[delucchi-cmu]

Re-generates local and cloud data for recent changes to on-disk data.

Tidies up some of the pytest fixtures while I'm in there.

[github-actions]

Before [2a35ae8]	After [02ab19d]	Ratio	Benchmark (Parameter)
1.74±1s	2.70±0.8s	~1.55	benchmarks.time_computation
208	632	3.04	benchmarks.mem_list

Click here to view all benchmarks.

[camposandro]

I like the notebook to upload the data to the cloud!

Should we still keep the copy_data_to_fs script so that we can copy data that we do not generate to the cloud? For example, the small_sky_parts that we use to generate small_sky and small_sky_order1 is also directly being used by hipscat-import:

https://github.com/astronomy-commons/hipscat-cloudtests/blob/c1167e852b59a9fb04b93716188ed170488e135b/tests/hipscat_import/conftest.py#L27-L28

[delucchi-cmu]

I like the notebook to upload the data to the cloud!

Should we still keep the copy_data_to_fs script so that we can copy data that we do not generate to the cloud? For example, the small_sky_parts that we use to generate small_sky and small_sky_order1 is also directly being used by hipscat-import:

https://github.com/astronomy-commons/hipscat-cloudtests/blob/c1167e852b59a9fb04b93716188ed170488e135b/tests/hipscat_import/conftest.py#L27-L28

I'll add that in a follow up. I broke the smoke test with these changes 😬