Skip to content

Commit

Permalink
Fix cores management
Browse files Browse the repository at this point in the history
  • Loading branch information
fjammes committed Apr 26, 2024
1 parent 570df04 commit 77fc90c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions _e2e/distribution.out.expected
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ spark-submit --master "k8s://https://127.0.0.1:34729" \
--conf "spark.executor.extraJavaOptions=-Djava.security.auth.login.config=/etc/fink-broker/kafka-jaas.conf" \
--conf spark.driver.memory=2Gi \
--conf spark.executor.memory=2Gi \
--conf spark.kubernetes.driver.request.cores=1 \
--conf spark.kubernetes.executor.request.cores=1 \
--conf spark.driver.cores=1 \
--conf spark.executor.cores=1 \
local:///home/fink/fink-broker/bin/distribute.py \
-log_level "INFO" \
-online_data_prefix "s3a://fink-broker-online-20000101" \
Expand Down
4 changes: 2 additions & 2 deletions _e2e/raw2science.out.expected
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ spark-submit --master "k8s://https://127.0.0.1:34729" \
--conf spark.executor.instances=4 \
--conf spark.driver.memory=3Gi \
--conf spark.executor.memory=3Gi \
--conf spark.kubernetes.driver.request.cores=1 \
--conf spark.kubernetes.executor.request.cores=1 \
--conf spark.driver.cores=1 \
--conf spark.executor.cores=1 \
local:///home/fink/fink-broker/bin/raw2science.py \
-log_level "INFO" \
-online_data_prefix "s3a://fink-broker-online-20000101" \
Expand Down
4 changes: 2 additions & 2 deletions cmd/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ org.apache.hadoop:hadoop-aws:3.2.3`
}
// TODO make it configurable at the task level
if rc.Cpu != "" {
cmdTpl += fmt.Sprintf(`--conf spark.kubernetes.driver.request.cores=%[1]s \
--conf spark.kubernetes.executor.request.cores=%[1]s \
cmdTpl += fmt.Sprintf(`--conf spark.driver.cores=%[1]s \
--conf spark.executor.cores=%[1]s \
`, rc.Cpu)
}
cmdTpl += `local:///home/fink/fink-broker/bin/{{ .Binary }} \
Expand Down

0 comments on commit 77fc90c

Please sign in to comment.